Messages in this thread | | | Subject | Re: [PATCH] UBI: rename free variable | From | Heiko Schocher <> | Date | Fri, 9 Oct 2015 08:29:05 +0200 |
| |
Hello Al,
Am 09.10.2015 um 07:39 schrieb Al Viro: > On Fri, Oct 09, 2015 at 06:39:52AM +0200, Heiko Schocher wrote: >> Hello Al, >> Sorry, I should have added this info immediately into the patch ... >> >> We have in U-Boot a compat.h file, in which we collect all things >> we need to make linux code running under U-Boot, and there we map >> kfree() to free(), see: >> >> http://git.denx.de/?p=u-boot.git;a=blob;f=include/linux/compat.h;h=fbebf910addd994d265d21c4fbaa0a2f48f4ccb1;hb=996ec1dcc58a34b53891acde0ec5df9141b5fcc2#l58 >> >> So, if we use a var name "free", this will conflict ... and I get >> for example when compiling the UBI code: >> >> CC drivers/mtd/ubi/fastmap.o >> drivers/mtd/ubi/fastmap.c: In function 'scan_pool': >> drivers/mtd/ubi/fastmap.c:475:3: error: called object 'free' is not a function >> >> So with this patch, we have less differences to kernel files ... > > Umm... wouldn't it be easier to replace that mix of #define and static inline > with uniform use of static inline, rather than playing whack-a-mole like > that?
Yes, fully correct, thanks for helping.
bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
| |