lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] USB: serial: cp210x: Workaround for cp2108 failure due to GET_LINE_CTL bug
Date
Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> writes:

> @@ -343,6 +344,28 @@ static int cp210x_get_config(struct usb_serial_port *port, u8 request,
> return result;
> }
>
> + /* Workaround for swapped bytes in 16-bit value from CP210X_GET_LINE_CTL */
> + if (spriv->swap_get_line_ctl && request == CP210X_GET_LINE_CTL && size == 2) {
> + union {
> + struct {
> + u8 byte0;
> + u8 byte1;
> + u8 byte2;
> + u8 byte3;
> + };
> + u32 as_u32;
> + } tmp_data;
> + u8 old_byte0;
> + u8 old_byte1;
> +
> + tmp_data.as_u32 = data[0]; /* from caller's buffer */
> + old_byte0 = tmp_data.byte0;
> + old_byte1 = tmp_data.byte1;
> + tmp_data.byte0 = old_byte1;
> + tmp_data.byte1 = old_byte0;
> + data[0] = tmp_data.as_u32; /* to caller's buffer */
> + }

That looks unnecessarily complicated... How about:

if (spriv->swap_get_line_ctl && request == CP210X_GET_LINE_CTL && size == 2)
swab16s((u16 *)data);


Completely untested...



Bjørn


\
 
 \ /
  Last update: 2015-10-08 10:01    [W:2.095 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site