lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
On Mon, 28 Sep 2015, Ben Hutchings wrote:

> rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> uninterruptible sleep still contribute to the load average (for
> bug-compatibility with Unix). A load average of ~1 on a system that
> should be idle is somewhat alarming.
>
> Change the sleep to be interruptible, but still ignore signals.
>
> A better fix might be to replace this loop with a delayed work item.
>
> References: https://bugs.debian.org/765717
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

Any chance you can use Git instead of Quilt? Failing that, is there a
way to tell Quilt to supply a diffstat in the patch?

> ---
> --- a/drivers/memstick/host/rtsx_usb_ms.c
> +++ b/drivers/memstick/host/rtsx_usb_ms.c
> @@ -706,7 +706,8 @@ poll_again:
> if (host->eject)
> break;
>
> - msleep(1000);
> + if (msleep_interruptible(1000))
> + flush_signals(current);
> }
>
> complete(&host->detect_ms_exit);



--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-10-08 09:41    [W:0.106 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site