lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] block: nvme-core: simplify ida usage
On Fri, 2 Oct 2015, Johannes Thumshirn wrote:
> Lee Duncan <lduncan@suse.com> writes:
>> Simplify ida index allocation and removal by
>> using the ida_simple_* helper functions.

Looks good to me. Just one comment:

>> static void nvme_release_instance(struct nvme_dev *dev)
>> {
>> spin_lock(&dev_list_lock);
>> - ida_remove(&nvme_instance_ida, dev->instance);
>> + ida_simple_remove(&nvme_instance_ida, dev->instance);
>> spin_unlock(&dev_list_lock);

No harm from taking the nvme spin lock here, but it's not necessary with
the simple interface.

> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>


\
 
 \ /
  Last update: 2015-10-08 16:41    [W:0.042 / U:1.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site