Messages in this thread | | | Date | Thu, 8 Oct 2015 14:29:48 +0000 (UTC) | From | Keith Busch <> | Subject | Re: [PATCH 3/5] block: nvme-core: simplify ida usage |
| |
On Fri, 2 Oct 2015, Johannes Thumshirn wrote: > Lee Duncan <lduncan@suse.com> writes: >> Simplify ida index allocation and removal by >> using the ida_simple_* helper functions.
Looks good to me. Just one comment:
>> static void nvme_release_instance(struct nvme_dev *dev) >> { >> spin_lock(&dev_list_lock); >> - ida_remove(&nvme_instance_ida, dev->instance); >> + ida_simple_remove(&nvme_instance_ida, dev->instance); >> spin_unlock(&dev_list_lock);
No harm from taking the nvme spin lock here, but it's not necessary with the simple interface.
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
| |