Messages in this thread | | | Date | Thu, 8 Oct 2015 19:47:59 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] PCC: fix dereference of ERR_PTR |
| |
On Wed, Sep 16, 2015 at 07:34:24PM +0530, Sudip Mukherjee wrote: > get_pcc_channel() does not return NULL on error it returns the error code > in ERR_PTR, but we have been checking it for NULL. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- A gentle ping.
regards sudip
> drivers/mailbox/pcc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > index 68885a8..45d85ae 100644 > --- a/drivers/mailbox/pcc.c > +++ b/drivers/mailbox/pcc.c > @@ -122,7 +122,7 @@ struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl, > */ > chan = get_pcc_channel(subspace_id); > > - if (!chan || chan->cl) { > + if (IS_ERR(chan) || chan->cl) { > dev_err(dev, "Channel not found for idx: %d\n", subspace_id); > return ERR_PTR(-EBUSY); > } > -- > 1.9.1 >
| |