Messages in this thread | | | Date | Thu, 08 Oct 2015 04:03:32 -0700 (PDT) | Subject | Re: [PATCH] af_unix: introduce unix_sk_const helper | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 06 Oct 2015 22:52:46 +0200
> Commit 124613012db1 ("af_unix: Convert the unix_sk macro to an inline > function for type safety") was recently added to catch incorrect > uses of the unix_sk helper using compiler warnings. > > It has now caught one such case in lsm_audit.c. The code is technically > correct, but as it converts a const pointer to a non-const pointer, > the annotation got lost, which gcc now warns about. > > This patch avoids the warning by introducing an additional helper > that has const input and output, which makes the lsm_audit code build > cleanly again. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > I'm not entirely happy with this workaround myself, but could not come > up with a better one.
You can make the argument unconditionally const, as Paul Moore has done in a separate patch submission.
| |