Messages in this thread | | | From | "Opensource [Adam Thomson]" <> | Subject | RE: [PATCH v2 3/3] ASoC: da7213: Add bindings documentation for codec driver | Date | Thu, 8 Oct 2015 08:42:23 +0000 |
| |
On October 07, 2015 17:22, Rob Herring wrote:
> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1 > > + [<1600>, <2200>, <2500>, <3000>] > > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2 > > + [<1600>, <2200>, <2500>, <3000>] > > Please append the units (-microvolt).
Given that a user needs to read the bindings document to understand what is available, and what they're for, this seems a little unnecessary.
> > > +- dlg,dmic-data-sel : DMIC channel select based on clock edge. > > + ["lrise_rfall", "lfall_rrise"] > > +- dlg,dmic-samplephase : When to sample audio from DMIC. > > + ["on_clkedge", "between_clkedge"] > > How about boolean for these two.
Wanted these to be explicit, hence not choosing boolean. Would prefer to keep them as is.
> > > +- dlg,dmic-clkrate : DMIC clock frequency (MHz). > > + [<1500000>, <3000000>] > > So 1.5GHz or 3GHz? > > Add units (-hz).
Agreed, the description of MHz is misleading so will update to Hz. Thanks. Again though, I don't see what the suffix gives you, and would prefer to leave the binding as is.
| |