Messages in this thread | | | Date | Thu, 8 Oct 2015 00:05:11 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support |
| |
On Wed, Oct 07, 2015 at 07:39:16PM +0300, Avi Kivity wrote: > That's what I thought as well, but apparently adding msix support to the > already insecure uio drivers is even worse.
I'm glad you finally agree what these drivers are doing is insecure.
And basically kernel cares about security, no one wants to maintain insecure stuff.
So you guys should think harder whether this code makes any sense upstream.
Getting support from kernel is probably the biggest reason to put code upstream, and this driver taints kernel unconditionally so you don't get that.
Alternatively, most of the problem you are trying to solve is for virtualization - and it is is better addressed at the hypervisor level. There are enough opensource hypervisors out there - work on IOMMU support there would be time well spent.
-- MST
| |