Messages in this thread | | | Date | Tue, 6 Oct 2015 08:56:53 +0100 | From | Greg KH <> | Subject | Re: [v6] serial: 8250_dw: Add support for big-endian MMIO accesses |
| |
On Tue, Oct 06, 2015 at 09:39:50AM +0300, Noam Camus wrote: > From: Noam Camus <noamc@ezchip.com> > > Add support for UPIO_MEM32BE in addition to UPIO_MEM32. > dw8250_serial_out32() extra functionality that is not part of > the 8250 core driver was moved to new function called > dw8250_check_LCR(). > > For big endian we use 2 new accessors similar to little endian, > called dw8250_serial_out32be() and dw8250_serial_in32be(). > Both little and big endian accessors use dw8250_check_LCR() > for their dw8250_serial_out32{,be}(). > > In addition I added another 2 accessors inside private_data field of > uart_port. This second level accessors are set during probe in > private_data field of uart_port. Now any direct call to readl/writel > is replaced with those accessors which are endianness aware. > > Last issue: > readl() for UCV and CPR will not work for port type UPIO_MEM32BE. > Instead we use the serial_in32() accessor which is initialized > properly according to endianness. > > Signed-off-by: Noam Camus <noamc@ezchip.com> > --- > drivers/tty/serial/8250/8250_dw.c | 72 ++++++++++++++++++++++++++++++++---- > 1 files changed, 64 insertions(+), 8 deletions(-)
Can you please fix the warnings as pointed out by the kbuild testing and resend this?
thanks,
greg k-h
| |