lkml.org 
[lkml]   [2015]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] string: Improve the generic strlcpy() implementation

* Ingo Molnar <mingo@kernel.org> wrote:

>
> * Ingo Molnar <mingo@kernel.org> wrote:
>
> > 2)
> >
> > Another problem is that strlcpy() will also happily do bad stuff if we pass
> > it a negative size. Instead of that we will from now on print a (one time)
> > warning and return safely.
>
> Hm, so this check is buggy, as 'size_t' is unsigned - and for some reason GCC
> didn't warn about the never-met comparison and the resulting unreachable dead
> code here:
>
> > + /* Overflow check: */
> > + if (unlikely(dest_size < 0)) {
> > + WARN_ONCE(1, "strlcpy(): dest_size < 0 underflow!");
> > + return strlen(src);
> > + }
>
> which is annoying.
>
> Would people object to something like:
>
> > + /* Overflow check: */
> > + if (unlikely((ssize_t)dest_size < 0)) {
> > + WARN_ONCE(1, "strlcpy(): dest_size < 0 underflow!");
> > + return strlen(src);
> > + }
>
> ?
>
> As I doubt it's legit to have larger than 2GB strings.
>
> Also, I'm wondering why GCC didn't warn.

Hm, so GCC (v4.9.2) will only warn about this bug if -Wtype-limits is enabled
explicitly:

lib/string.c: In function ‘strlcpy’:
lib/string.c:228:32: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (unlikely((size_t)dst_size < 0)) {
^

... which we don't do in the kernel.

Has anyone considered enabling -Wtype-limits? It seems to catch real bugs.

I can see there are patches that enable -Wextra (which enables -Wtype-limits and
many other warnings), but it would be more manageable to just enable one such
warning at a time.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-10-05 15:41    [W:1.492 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site