lkml.org 
[lkml]   [2015]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: print function name of callbacks
On Tue 2015-09-22 10:26:37, Douglas Anderson wrote:
> The printouts writen to the logs by suspend can be a bit opaque: it can
> be hard to track them down to the actual function called. You might
> see:

It seems simple enough.

Acked-by: Pavel Machek <pavel@ucw.cz>

> +static ktime_t initcall_debug_start(struct device *dev, void *cb)
> {
> ktime_t calltime = ktime_set(0, 0);
>
> if (pm_print_times_enabled) {
> - pr_info("calling %s+ @ %i, parent: %s\n",
> + pr_info("calling %s+ @ %i, parent: %s, cb: %pf\n",
> dev_name(dev), task_pid_nr(current),
> - dev->parent ? dev_name(dev->parent) : "none");
> + dev->parent ? dev_name(dev->parent) : "none", cb);
> calltime = ktime_get();
> }
>
> @@ -382,7 +382,7 @@ static int dpm_run_callback(pm_callback_t cb, struct device *dev,
> if (!cb)
> return 0;
>
> - calltime = initcall_debug_start(dev);
> + calltime = initcall_debug_start(dev, cb);
>
> pm_dev_dbg(dev, state, info);
> trace_device_pm_callback_start(dev, info, state.event);
> @@ -1324,7 +1324,7 @@ static int legacy_suspend(struct device *dev, pm_message_t state,
> int error;
> ktime_t calltime;
>
> - calltime = initcall_debug_start(dev);
> + calltime = initcall_debug_start(dev, cb);
>
> trace_device_pm_callback_start(dev, info, state.event);
> error = cb(dev, state);
> --
> 2.6.0.rc0.131.gf624c3d

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2015-10-04 17:41    [W:0.072 / U:1.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site