Messages in this thread | | | Subject | Re: [PATCH 2/2] dma: add Qualcomm Technologies HIDMA channel driver | From | Timur Tabi <> | Date | Fri, 30 Oct 2015 17:36:45 -0500 |
| |
On 10/30/2015 05:28 PM, Arnd Bergmann wrote: >>> > >Why ENODEV? Could you make this handle restarted system calls? >> > >> >This is the self test code. It gets called from probe. If there is a >> >problem with the device or system configuration, I don't want to enable >> >this device. I can certainly return a different error code though. >> >What's a good code? > I see. probe() is not restartable, so it cannot be -ERESTARTSYS. > > Maybe better use wait_event_timeout and not handle the signals then. > It will eventually time out if something goes wrong.
What about -EPROBE_DEFER? Isn't that "restartable"? Granted, it's only supposed to be used if the driver is dependent on another driver to probe, so I'm not sure it applies here. If the self-test fails, then it is possible that it could succeed later?
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |