lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/19] clk: sunxi: Add TCON channel1 clock
    On 10/30, Maxime Ripard wrote:
    > The TCON is a controller generating the timings to output videos signals,
    > acting like both a CRTC and an encoder.
    >
    > It has two channels depending on the output, each channel being driven by
    > its own clock (and own clock controller).
    >
    > Add a driver for the channel 1 clock.
    >
    > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

    Similar comments apply to patches 3 and 4. Was the same code
    copy/pasted two more times and then changed to have different
    values? Looks like we should consolidate all that stuff into
    something more generic so that we don't have the same problems 3
    times.

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project


    \
     
     \ /
      Last update: 2015-10-30 23:01    [W:4.123 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site