lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval
    From
    Date
    Hi,

    On Fri, 2015-10-30 at 01:30 -0700, Tina Ruchandani wrote:
    > Function stex_gettime uses 'struct timeval' whose tv_sec value
    > will overflow on 32-bit systems in year 2038 and beyond. This patch
    > replaces the use of struct timeval and do_gettimeofday with
    > ktime_get_real_seconds, which returns a 64-bit seconds value.

    Thanks for the conversion. Can you please check if other (scsi) drivers
    have the same y2038 issues? A quick "git grep do_gettimeofday
    drivers/scsi/  | wc -l" reveals 30 occurrences (of cause not all are
    problematic).


    Other than that
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>




    \
     
     \ /
      Last update: 2015-10-30 10:01    [W:4.537 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site