lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs
Date
On Thu, Oct 29, 2015 at 11:50:47PM +0200, Kirill A. Shutemov wrote:
...
>
> Okay, the problem is that the page was freed under stable_page_flags().
>
> Is the code performance sensitive? Can we get reference to the page before
> touching it? If not, we can rewrite the helper like this:
>
> static inline int PageDoubleMap(struct page *page)
> {
> return PageHead(page) && test_bit(PG_double_map, &page[1].flags);
> }
>
> Just dropping the check would be wrong, I think, as we access the next
> page.
>

I don't think this interface is performance sensitive, but hopefully the
impact on other workload is minimum. So I like the above rewritten one.

Thanks,
Naoya Horiguchi

\
 
 \ /
  Last update: 2015-10-30 09:41    [W:0.099 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site