lkml.org 
[lkml]   [2015]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 3/3] USB: serial: cp210x: Workaround cp2108 GET_LINE_CTL bug
    On Wed, Oct 28, 2015 at 09:51:26AM +0100, Johan Hovold wrote:
    > On Tue, Oct 27, 2015 at 04:53:34PM -0500, Konstantin Shkolnyy wrote:
    > > cp2108 GET_LINE_CTL returns the 16-bit value with the 2 bytes swapped.
    > > However, SET_LINE_CTL functions properly. When the driver tries to modify
    > > the register, it reads it, modifies some bits and writes back. Because the
    > > read bytes were swapped, this often results in an invalid value to be
    > > written. In turn, this causes cp2108 respond with a stall. The stall
    > > sometimes doesn't clear properly and cp2108 starts responding to following
    > > valid commands also with stalls, effectively failing.
    > >
    > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>

    > I gave the series a really quick test on an cp2102-device I had lying
    > around. I assume you verified the changes on some other older devices as
    > well?

    Did you test this series on the older device types as well?

    Thanks,
    Johan


    \
     
     \ /
      Last update: 2015-10-29 08:41    [W:5.153 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site