Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 28 Oct 2015 16:00:45 +0900 | From | Darren Hart <> | Subject | Re: [PATCH 07/10] merge_config.sh: add tests |
| |
On Wed, Oct 28, 2015 at 09:42:08AM +0900, Olof Johansson wrote: > For being a small script, merge_config.sh is fairly scary to change since there's no > real way to know if you did something wrong. So it seems appropriate to add a simple > test suite. > > I've started with testcases in the areas I care about, other should of course feel > free to expand on this. > > Use is simple, from the kernel tree, run ./scripts/kconfig/merge_config_test/runall. > It'll execute out of a tmpdir under /tmp. > > Signed-off-by: Olof Johansson <olof@lixom.net>
Thanks for writing the test cases. Shell scripting is so easy to bikeshed - so I'm going to skip that. I didn't catch any bashisms, and the test coverage is good.
Reviewed-by: Darren Hart <dvhart@linux.intel.com>
-- Darren Hart Intel Open Source Technology Center
| ![\](/images/icornerr.gif) |