lkml.org 
[lkml]   [2015]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: kmemleak: mark kmemleak_init prototype as __init
On Sun, Jul 05, 2015 at 02:47:01AM +0100, Nicolas Iooss wrote:
> kmemleak_init() definition in mm/kmemleak.c is marked __init but its
> prototype in include/linux/kmemleak.h is marked __ref since commit
> a6186d89c913 ("kmemleak: Mark the early log buffer as __initdata").
>
> This causes a section mismatch which is reported as a warning when
> building with clang -Wsection, because kmemleak_init() is declared in
> section .ref.text but defined in .init.text.
>
> Fix this by marking kmemleak_init() prototype __init.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> include/linux/kmemleak.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h
> index d0a1f99e24e3..4894c6888bc6 100644
> --- a/include/linux/kmemleak.h
> +++ b/include/linux/kmemleak.h
> @@ -25,7 +25,7 @@
>
> #ifdef CONFIG_DEBUG_KMEMLEAK
>
> -extern void kmemleak_init(void) __ref;
> +extern void kmemleak_init(void) __init;
> extern void kmemleak_alloc(const void *ptr, size_t size, int min_count,
> gfp_t gfp) __ref;
> extern void kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

I forgot about this patch. Andrew, could you please queue this patch for
4.4? Thanks.

--
Catalin



\
 
 \ /
  Last update: 2015-10-28 17:21    [W:0.254 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site