lkml.org 
[lkml]   [2015]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v12 5/6] ARM: socfpga: add bindings document for fpga bridge drivers
    On Wed, 28 Oct 2015, Steffen Trumtrar wrote:

    > Hi!
    >
    > On Tue, Oct 27, 2015 at 05:09:14PM -0500, atull@opensource.altera.com wrote:
    > > From: Alan Tull <atull@opensource.altera.com>
    > >
    > > Add bindings documentation for Altera SOCFPGA bridges:
    > > * fpga2sdram
    > > * fpga2hps
    > > * hps2fpga
    > > * lwhps2fpga
    > >
    > > Signed-off-by: Alan Tull <dinguyen@opensource.altera.com>
    > > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
    > > Signed-off-by: Matthew Gerlach <mgerlach@altera.com>
    > > ---
    > > v2: separate into 2 documents for the 2 drivers
    > > v12: bump version to line up with simple-fpga-bus version
    > > remove Linux specific notes such as references to sysfs
    > > move non-DT specific documentation elsewhere
    > > remove bindings that would have been used to pass configuration
    > > clean up formatting
    > > ---
    > > .../bindings/fpga/altera-fpga2sdram-bridge.txt | 18 ++++++++++
    > > .../bindings/fpga/altera-hps2fpga-bridge.txt | 36 ++++++++++++++++++++
    > > 2 files changed, 54 insertions(+)
    > > create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
    > > create mode 100644 Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
    > >
    > > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
    > > new file mode 100644
    > > index 0000000..11eb5b7
    > > --- /dev/null
    > > +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
    > > @@ -0,0 +1,18 @@
    > > +Altera FPGA To SDRAM Bridge Driver
    > > +
    > > +Required properties:
    > > +- compatible : Should contain "altr,socfpga-fpga2sdram-bridge"
    > > +
    > > +Optional properties:
    > > +- label : User-readable name for this bridge.
    > > + Default is br<device#>
    > > +- init-val : 0 if driver should disable bridge at startup
    > > + 1 if driver should enable bridge at startup
    > > + Default is to leave bridge in current state.
    >
    > I know, that there are bindings, that configure via devicetree, but AFAIK
    > this is not okay.

    Yes there is configuration in the DT. I attended a presentation at ELC in
    Dublin 3 weeks ago - Frank Rowand on "Solving Device Tree Issues." He said in
    addition to non-probable hardware information, it was a "dirty secret" that DT
    includes configuration information and some policy.

    Alan


    \
     
     \ /
      Last update: 2015-10-28 17:21    [W:2.706 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site