Messages in this thread | | | Date | Wed, 28 Oct 2015 16:11:41 +0100 | Subject | Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16 | From | Linus Walleij <> |
| |
On Tue, Oct 27, 2015 at 5:51 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > On Tue, Oct 27, 2015 at 05:42:23PM +0100, Linus Walleij wrote: >> On Tue, Oct 27, 2015 at 3:23 PM, Mika Westerberg >> <mika.westerberg@linux.intel.com> wrote: >> > On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: >> >> > +menu "ISA GPIO drivers" >> >> > + >> >> > +config GPIO_104_IDIO_16 >> >> > + tristate "ACCES 104-IDIO-16 GPIO support" >> >> > + depends on X86 >> >> > + help >> >> > + Enables GPIO support for the ACCES 104-IDIO-16 family. >> >> > + >> >> > +endmenu >> >> >> >> I have five other drivers using port-based I/O: >> >> >> >> gpio-f7188x.c >> >> gpio-it87.c >> >> gpio-sch.c >> >> gpio-sch311x.c >> >> gpio-ts5500.c >> >> >> >> Do you think it makes sense to move all of these in under >> >> the "ISA GPIO drivers" menu as well? I guess they all require >> >> ISA after all. >> >> >> >> (Added their maintainers to the To: line so I can get some input >> >> on this.) >> > >> > Not all of them actually require ISA. For example gpio-sch is part of an >> > MFD device which is a PCI device. PCI bus also has notion of I/O ports. >> >> Hm, is there a more fitting symbol we should sort it under, which >> means thingofabob-that-has-portmapped I/O? > > Well, there's already "Memory mapped GPIO drivers" so how about "I/O > mapped GPIO drivers"?
Sure, "Port-mapped I/O GPIO drivers"
But what should I put as "depends" for that submenu, that is maybe the real question.
Would (ISA || PCI) suffice?
Yours, Linus Walleij
| |