lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] PM / suspend: replacing printk
From
Date
Am 27.10.2015 um 20:32 schrieb Saurabh Sengar:
> it fixes the checkpatch.pl <http://checkpatch.pl> warnings

Don't get me wrong, but checkpatch.pl is only a script which makes suggestions.
Especially as these are only warnings and not errors.

IMHO the code is perfectly fine as is.

Thanks,
//richard

> On Oct 28, 2015 12:56 AM, "Richard Weinberger" <richard.weinberger@gmail.com <mailto:richard.weinberger@gmail.com>> wrote:
>>
>> On Tue, Oct 27, 2015 at 8:21 PM, Saurabh Sengar <saurabh.truth@gmail.com <mailto:saurabh.truth@gmail.com>> wrote:
>> > replacing prink(s) with appropriate pr_info and pr_err
>> >
>> > Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com <mailto:saurabh.truth@gmail.com>>
>> > ---
>> > kernel/power/suspend.c | 6 +++---
>> > 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> In which way does this patch improve the existing code?
>> You describe what it does but not which problem it solves and
>> why this patch is necessary.
>>
>> --
>> Thanks,
>> //richard
>


\
 
 \ /
  Last update: 2015-10-27 21:01    [W:0.036 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site