lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings
From
Date
On 10/27/2015 11:22 AM, ygardi@codeaurora.org wrote:
>> On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote:
>>>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
>>>>> Tnis patch fixes the following compilation warnings:
>>>>> ...ufs-qcom.c:1201:40:
>>>>> warning: incorrect type in argument 1 (different address spaces)
>>>>> ...ufs-qcom.c:1201:40:
>>>>> expected void const *ptr
>>>>> ...ufs-qcom.c:1201:40:
>>>>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>> ...ufs-qcom.c:1207:53:
>>>>> warning: incorrect type in argument 1 (different address spaces)
>>>>> ...ufs-qcom.c:1207:53:
>>>>> expected void const *ptr
>>>>> ...ufs-qcom.c:1207:53:
>>>>> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>>
>>>>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>>>>>
>>>>> ---
>>>> What version of sparse do you use? You shouldn't need to do this.
>>>>
>>> i just updated my sparse to the newest -
>>> so i'm using sparse 0.4.4
>>> and the command i use is:
>>> make ARCH=arm C=1 CF="-Wsparse-all"
>>> and i still get all the warnings.
>>> with my patch, the are no warnings.
>>>
>> That is not the latest version of sparse. I'm not sure when sparse was
>> updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db
>>
> Stephen, is this something you insist on?
> i think the patch can stay as it is.
> please let me know, as i wouldn't like this issue to block the entire patch
>

Yes. Adding __force is wrong. Just drop this patch.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project



\
 
 \ /
  Last update: 2015-10-27 20:01    [W:0.031 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site