Messages in this thread | | | Date | Tue, 27 Oct 2015 11:13:35 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 11/52] perf tools: Add stat config event |
| |
Em Tue, Oct 27, 2015 at 02:51:54PM +0100, Jiri Olsa escreveu: > On Tue, Oct 27, 2015 at 10:44:40AM -0300, Arnaldo Carvalho de Melo wrote: > > > I think we could easily add record specific event for this > > > once it's needed.. there's plenty of free numbers in user > > > events area ;-)
> > Shhh, don't ask PeterZ about it ;-)
> > But seriously, what makes this specific? Do you envision the stat code > > needing 2^64-1 tags?
> nope ;-)
> it's just the read function perf_event__read_stat_config takes the > 'struct perf_stat_config *' and updates it based on the event data.
> we would need to change the code to be more generic.. but as you said, > it's future ;-)
Right, I applied the patch, I was just curious if I was missing some detail that would prevent us from using this as a generic tag/value perf.data storing facility.
- Arnaldo
| |