Messages in this thread | | | Date | Tue, 27 Oct 2015 12:12:01 +0100 | From | Bogicevic Sasa <> | Subject | Re: [PATCH] Staging:drivers:wlan_ng: code style issues |
| |
Thanks, I get it now, Ill will group all changes and resend the patches On 10/27/2015, Greg KH wrote: >On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: >> On 10/26, Bogicevic Sasa wrote: >> >Thanks for the review just sent the new patch, >> >since change is very trivial I believe one liner like "fix all coding >> >style issues in that and that file" is descriptive enough. > >No, not at all, that's not how we make kernel changes, look in the logs >for specifics. Each patch needs to be descriptive and only do one >thing. And as I said before "fix all coding style issues", is _NOT_ >"one thing". > >Please break it up into logical patches, _AND_ use checkpatch.pl to >properly send the patches to the correct mailing list and developers. > >thanks, > >greg k-h
| |