lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] gpio: generic: Revert to old error handling in bgpio_map
From
On Wed, Oct 21, 2015 at 9:12 AM, Guenter Roeck <linux@roeck-us.net> wrote:

> Returning an error instead of NULL in bgpio_map if
> platform_get_resource_byname does not find a resource was introduced with
> commit cf3f2a2c8bae ("gpio: generic: improve error handling in bgpio_map").
> This results in several qemu runtime failures with default and non-default
> configurations, if attempts are made to boot from mmcblk0. Examples for
> failures with multi_v7_defconfig are
>
> Machine: vexpress-a9 dtb: vexpress-v2p-ca9
> Machine: vexpress-a15 dtb: vexpress-v2p-ca15-tc1
>
> Crash:
>
> VFS: Cannot open root device "mmcblk0" or unknown-block(0,0): error -6
> Please append a correct "root=" boot option; here are the available partitions:
> Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
>
> Looking into the code, always returning an error if bgpio_map fails
> does not appear to make much sense, since the code in bgpio_setup_io
> specifically supports some of the resources to be NULL.
>
> Fixes: cf3f2a2c8bae ("gpio: generic: improve error handling in bgpio_map")
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Patch/revert applied. Thanks for digging in and fixing this Günther!

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-10-27 11:41    [W:0.042 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site