Messages in this thread | | | Date | Tue, 27 Oct 2015 12:27:23 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [tpmdd-devel] [PATCH] TPM: Avoid reference to potentially freed memory |
| |
On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote: > > Reference to the 'np' node is dropped before dereferencing the 'sizep' and > > 'basep' pointers, which could by then point to junk if the node has been > > freed. > > > > Refactor code to call 'of_node_pup' later. > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > LGTM.
Is there anyone able to provide Tested-by for this?
Christophe, were you able to reproduce the crash (insmod/rmmod couple of times maybe?) and validate that it was gone after fixing the bug?
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
| |