lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path
On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote:
> -error_cleanup_open:
> +dprc_scan_container_error:
> (void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);

The error label was better in the original code. A "goto
error_cleanup_open", that tells you what the goto does. "goto
dprc_scan_container_error" tells you nothing because you can see from
the line before that there was a container error. No new information.
It's just like a function name tells you what a function does. You
wouldn't name the function called_from_main().

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-10-27 11:21    [W:0.075 / U:1.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site