Messages in this thread | | | Subject | Re: [PATCH V3 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA | From | Jon Hunter <> | Date | Tue, 27 Oct 2015 09:24:01 +0000 |
| |
On 27/10/15 02:10, Vinod Koul wrote: > On Fri, Oct 16, 2015 at 08:35:19AM +0100, Jon Hunter wrote: >> +static inline void tdma_ch_write(struct tegra_adma_chan *tdc, >> + u32 reg, u32 val) > > Coding style issue here
Yes will correct.
>> +static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) >> +{ >> + struct tegra_adma_chan *tdc = to_tegra_adma_chan(dc); >> + int ret; >> + >> + ret = pm_runtime_get_sync(tdc2dev(tdc)); >> + if (ret) >> + return ret; > > pm_runtime_get_sync() return postive values on success too, so this can > fail. This check should be for less than zero case
I stumbled upon that recently and will also fix up.
Cheers Jon
| |