Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] ACPI/PAD: power_saving_thread() is not freezable | Date | Wed, 28 Oct 2015 04:18:52 +0100 |
| |
On Monday, October 26, 2015 04:02:01 AM Jiri Kosina wrote: > From: Jiri Kosina <jkosina@suse.cz> > > power_saving_thread() calls try_to_freeze(), but the thread doesn't mark > itself freezable through set_freezable(), so the try_to_freeze() > call is useless. > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > --- > drivers/acpi/acpi_pad.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c > index ae307ff..8ea8211 100644 > --- a/drivers/acpi/acpi_pad.c > +++ b/drivers/acpi/acpi_pad.c > @@ -148,8 +148,6 @@ static int power_saving_thread(void *data) > while (!kthread_should_stop()) { > unsigned long expire_time; > > - try_to_freeze(); > - > /* round robin to cpus */ > expire_time = last_jiffies + round_robin_time * HZ; > if (time_before(expire_time, jiffies)) { >
Applied, thanks!
Rafael
| |