lkml.org 
[lkml]   [2015]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Input: tsc2005 - Add support for tsc2004
Hi Michael,
On Tue, Oct 27, 2015 at 07:17:01PM -0500, Michael Welling wrote:
> Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver
> due to the similarity of the devices.
>
> Signed-off-by: Michael Welling <mwelling@ieee.org>
> ---
> v2: Fixes Kconfig based on report for 0-day build bot.
>
> .../bindings/input/touchscreen/tsc2004.txt | 38 ++++
> drivers/input/touchscreen/Kconfig | 7 +-
> drivers/input/touchscreen/tsc2005.c | 206 ++++++++++++++++-----

Could we maybe split the code into core, spi and i2c drivers instead of
keeping everything together and rely on #ifdefs?

Thanks!

--
Dmitry


\
 
 \ /
  Last update: 2015-10-28 03:21    [W:0.112 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site