Messages in this thread | | | Subject | Re: [PATCH 6/9] Bluetooth: btmrvl: add missing of_node_put | From | Marcel Holtmann <> | Date | Mon, 26 Oct 2015 04:54:04 +0900 |
| |
Hi Julia,
> for_each_compatible_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression e; > local idexpression n; > @@ > > for_each_compatible_node(n, ...) { > ... when != of_node_put(n) > when != e = n > ( > return n; > | > + of_node_put(n); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/bluetooth/btmrvl_main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
| |