Messages in this thread | | | Date | Sun, 25 Oct 2015 13:27:15 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 19/57] perf tools: Add attr_update event |
| |
On Thu, Oct 22, 2015 at 10:01:46AM +0200, Jiri Olsa wrote: > On Mon, Oct 19, 2015 at 06:00:04PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 16, 2015 at 12:40:54PM +0200, Jiri Olsa escreveu: > > > It'll server as base event for additional event attributes > > > details, that are not part of the attr event. > > > > > > At the moment this event is just dummy one without specific > > > functionality. The type value will distinguish the update > > > event details. It comes in following patches. > > > > > > The idea for this event is to be extensible for any update > > > that attr event might need in the future. > > > > "Update"? Found it confusing, how about calling it "add event > > attribute", because that is what this is doing, adding attributes, like > > "unit" (Joules, MiB, nsec, etc), "scale", etc. > > well, we have PERF_RECORD_HEADER_ATTR event based on which the > event is created.. so PERF_RECORD_HEADER_ATTR_UPDATE seemed > like good choice.. anyway, how about: > > PERF_RECORD_ADD_EVENT_ATTR > PERF_RECORD_EVENT_ATTR > PERF_RECORD_EVENT_UPDATE
choosing the PERF_RECORD_EVENT_UPDATE for next version..
jirka
| |