lkml.org 
[lkml]   [2015]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Re: [PATCH 00/26] tracing: 'hist' triggers
Date
From: Tom Zanussi [mailto:tom.zanussi@linux.intel.com]
>
>Hi Masami,
>
>On Thu, 2015-10-22 at 20:17 +0900, Masami Hiramatsu wrote:
>> Hi Tom,
>>
>> I've tested your series of the hist trigger v10 with
>> these testcases included in the couple of patches, which
>> tests following features.
>>
>> - traceon-traceoff trigger
>> - enable/disable_event trigger
>> - snapshot trigger
>> - stacktrace trigger
>> - trigger filters
>>
>> - Histogram trigger itself
>> - Histogram with string key
>> - Histogram with compound keys
>> - Histogram with sort key
>> - Histogram trigger modifiers (execname, hex, syscall)
>> - Multiple histograms on an event
>> - Named histogram
>> - Named histogram on multi events
>>
>> Here is the test result.
>> ----
>> # ./ftracetest test.d/trigger/
>> === Ftrace unit tests ===
>> [1] event trigger - test event enable/disable trigger [PASS]
>> [2] event trigger - test trigger filter [PASS]
>> [3] event trigger - test histogram modifiers [PASS]
>> [4] event trigger - test histogram trigger [PASS]
>> [5] event trigger - test multiple histogram triggers [PASS]
>> [6] event trigger - test snapshot-trigger [PASS]
>> [7] event trigger - test stacktrace-trigger [PASS]
>> [8] event trigger - test traceon/off trigger [PASS]
>>
>> # of passed: 8
>> # of failed: 0
>> # of unresolved: 0
>> # of untested: 0
>> # of unsupported: 0
>> # of xfailed: 0
>> # of undefined(test bug): 0
>> ----
>>
>
>Hey, this is great, thanks for creating this!

Thanks!

>I'm looking forward to moving as many of my current set of tests to your
>framework as I can:
>
>http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-contrib/commit/?h=tzanussi/hist-triggers-test&id=53d7d47bac3340b2160bf2a5b48268d
>6c7516734

Sounds nice! :)

>I run all of the above tests manually every time I make a significant
>change, which is about 2 hours of solid tedious work each time through.
>Obviously it's about time to automate - thanks for providing the
>framework to finally help do that.

Yeah, the ftracetest is already integrated to kselftests, so it is helpful to
prove your code has no side-effects too :)

>
>> So I'm OK for your hist trigger series.
>> If you would not mind, please include these patches and my tested-by
>> in your series to prove your series is good :)
>>
>> Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>
>
>Sure, I'll do that, new series coming up shortly..

Thanks again!


\
 
 \ /
  Last update: 2015-10-23 09:01    [W:0.125 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site