Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper | From | Alexei Starovoitov <> | Date | Fri, 23 Oct 2015 07:42:22 -0700 |
| |
On 10/23/15 5:03 AM, Peter Zijlstra wrote: > So the bpf_perf_event_read() returns the count value, does this not also > mean that returning -EINVAL here is also 'wrong'? > > I mean, sure an actual count value that high is unlikely, but its still > a broken interface.
Agree. that's not pretty interface. I wish I looked at it more carefully when it was introduced. Now it's too late to change.
| ![\](/images/icornerr.gif) |