Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 22 Oct 2015 13:38:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] ASoC: Codec: wm8962: declare ALC Coefficients as 4 separate registers |
| |
On Tue, Oct 20, 2015 at 11:47:12AM +0900, Jiada Wang wrote: > As ALC2 register is volatile, declare it as one of ALC Coefficients > register together with other non-volatile registers will cause issue, > in case wm8962 has enter suspend mode, and cache_only flag is set, > any attempt to read from ALC2 will fail. > > Instead of declaring one ALC Coefficients register which contains > ALC1 ~ ALC3 and Noise Gate, this patch declares 4 separate registers, > so that regmap can handle these registers differently based on their > classification.
In addition to the issue with the ABI change that Charles raised this also doesn't entirely fix the issue in that we still have a control that is going to give an error in suspend mode. Charles' suggestion seems like it's more likely to be helpful to users. [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |