lkml.org 
[lkml]   [2015]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: block: re-add discard_granularity and alignment checks
On Thu, Oct 22 2015 at 12:59pm -0400,
Ming Lin <mlin@kernel.org> wrote:

> From: Ming Lin <ming.l@ssi.samsung.com>
>
> In commit b49a087("block: remove split code in
> blkdev_issue_{discard,write_same}"), discard_granularity and alignment
> checks were removed. Ideally, with bio late splitting, the upper layers
> shouldn't need to depend on device's limits.
>
> Christoph reported a discard regression on the HGST Ultrastar SN100 NVMe
> device when mkfs.xfs. We have not found the root cause yet.
>
> This patch re-adds discard_granularity and alignment checks by reverting
> the related changes in commit b49a087. The good thing is now we can
> remove the 2G discard size cap and just use UINT_MAX to avoid bi_size
> overflow.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>

Reviewed-by: Mike Snitzer <snitzer@redhat.com>

Thanks!


\
 
 \ /
  Last update: 2015-10-22 19:21    [W:0.184 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site