Messages in this thread | | | From | Yoshihiro Shimoda <> | Subject | RE: [PATCH] serial: sh-sci: Fix length of scatterlist | Date | Thu, 22 Oct 2015 06:36:23 +0000 |
| |
Hi Geert-san,
> Sent: Tuesday, October 20, 2015 9:22 PM > > Hi Shimoda-san, > > On Tue, Oct 20, 2015 at 2:18 PM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > This patch fixes an issue that the "length" of scatterlist should be > > set using sh_dma_length(). Otherwise, a dmaengine driver cannot work > > sg_dma_len()?
Thank you for the point. I will fix it.
> > correctly if CONFIG_NEED_SG_DMA_LENGTH=y. > > > > Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is enabled) > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > drivers/tty/serial/sh-sci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > > index 960e50a..284a872 100644 > > --- a/drivers/tty/serial/sh-sci.c > > +++ b/drivers/tty/serial/sh-sci.c > > @@ -1437,7 +1437,7 @@ static void sci_request_dma(struct uart_port *port) > > sg_init_table(sg, 1); > > s->rx_buf[i] = buf; > > sg_dma_address(sg) = dma; > > - sg->length = s->buf_len_rx; > > + sg_dma_length(sg) = s->buf_len_rx; > > There's no definition for "sg_dma_length" in my tree?? sg_dma_len()?
Oops! Thank you for the point. I will fix it.
Best regards, Yoshihiro Shimoda
> Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |