Messages in this thread | | | Date | Wed, 21 Oct 2015 16:29:02 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller' |
| |
Hi Brendan,
On Mon, Oct 19, 2015 at 04:50:11PM -0700, Brendan Gregg wrote: > On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim <namhyung@kernel.org> wrote: > > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > >> From: Arnaldo Carvalho de Melo <acme@redhat.com> > >> > >> Which is the most common default found in other similar tools. > > > > I think it's more useful to change the default only when --children is > > used. And there's a related issue too - please see below link: > > > > https://lkml.org/lkml/2014/8/14/49 > > --children is default for things like "perf report --stdio" and > (implied) "perf script", so any change to --children is a change to > default.
Hmm.. right. It should change the default only when --children is actually used in "perf report" or "perf top" so that "perf script" or other commands should not be changed.
Thanks, Namhyung
| |