Messages in this thread | | | Date | Wed, 21 Oct 2015 08:05:20 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power |
| |
Hi Rui,
On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote: > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > > On 10/20/2015 07:40 PM, Huang Rui wrote: > > >>>Thanks to report this issue. :) > > >>>The root cause is that the test config doesn't enable > > >>>CONFIG_CPU_SUP_AMD. > > >>> > > >>>How about below fix: > > >>> > > >> > > >>Guess you don't have a choice. > > >> > > > > > >Yes, if I use test config, fam15h_power isn't chosen. :) > > > > > >And if I use the "select" flag like below, fam15h_power can be built > > >successfully. > > > > > That is another possibility, though that isn't how CPU_SUP_AMD > > is handled by its other users. Matter of philosophy, I guess. > > Err, sorry. Could you please point out the other possibility?
Both possibilities came from you. First one is to use "depends", second one is to use "select".
As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE, AMD_NB) use "depends" so you should do the same for consistency.
-- Jean Delvare SUSE L3 Support
| |