lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] tracing: Have stack tracer force RCU to be watching
On Wed, 21 Oct 2015 10:01:42 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> > I should probably add a "if (in_nmi()) return" somewhere.
>
> But if there's an arch that doesn't use a separate NMI stack, the NMI
> might cause the largest stack, which would then remain invisible from
> the stack-tracer.
>
> Should we not instead fix the NMI-safety of this tracer?

We could, but that should be a separate project, as that would require
doing everything lockless, which would require a redesign. Is that
worth it?

For now, the safe thing to do is the if (in_nmi()), but certainly, if
someone gets time to make it NMI safe, we can do that too.

-- Steve


\
 
 \ /
  Last update: 2015-10-21 14:01    [W:0.093 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site