lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces
    Date
    The thinkpad_acpi driver currently emits error messages on unsupported
    brightness interfaces, giving the impression that someone will implement
    those. However, this error is spit out on nearly every thinkpad in
    production since 2 years now. Furthermore, the backlight interfaces on
    those devices are supported by the i915 driver just fine.

    Downgrade the error message to a normal pr_info() and stop telling people
    to report it to IBM.

    Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
    ---
    drivers/platform/x86/thinkpad_acpi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
    index 131dd74..0bed473 100644
    --- a/drivers/platform/x86/thinkpad_acpi.c
    +++ b/drivers/platform/x86/thinkpad_acpi.c
    @@ -6459,8 +6459,7 @@ static void __init tpacpi_detect_brightness_capabilities(void)
    pr_info("detected a 8-level brightness capable ThinkPad\n");
    break;
    default:
    - pr_err("Unsupported brightness interface, "
    - "please contact %s\n", TPACPI_MAIL);
    + pr_info("Unsupported brightness interface\n");
    tp_features.bright_unkfw = 1;
    bright_maxlvl = b - 1;
    }
    --
    2.6.1


    \
     
     \ /
      Last update: 2015-10-21 13:01    [W:7.469 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site