Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 21 Oct 2015 21:52:07 -0500 | From | Andy Gross <> | Subject | Re: [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator |
| |
On Tue, Oct 20, 2015 at 07:57:53PM +0300, Georgi Djakov wrote: > Add the on-board XO oscillator. This patch prepares for adding support > for RPM controlled clocks. In order to do smooth transition and support > both cases (RPM clock driver is enabled or nor), we first move the XO to > the DT and change the GCC fixed-rate root clock to a dummy pass-through > clock. Then if the RPM driver is enabled, we set the parent of the XO > clock in the RPM clock driver to xo_board. > The advantage of doing so is that the rate of the XO clock is not hard- > coded in the GCC driver anymore, but comes from the board layout, so > that is why it should be in DT anyway. > > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> > ---
Looks good to me.
Reviewed-by: Andy Gross <agross@codeaurora.org>
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| ![\](/images/icornerr.gif) |