lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 0/9] Add tune support of Mediatek MMC driver
    From
    Date
    On Tue, 2015-10-20 at 18:41 +0200, Ulf Hansson wrote:
    > On 20 October 2015 at 11:13, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
    > > Change in v2:
    > > Drop the 400mhz and use assigned-clock-parents to instead
    > > Split the original tune patch to several independent patches
    > > Re-write the mmc_send_tuning()
    > > Fix GPD checksum error
    > > Move the HS400 setting to ops->prepare_hs400_tuning()
    > > Modify SD driving settings
    > >
    > > Change in v1:
    > > Add DT bindings for eMMC hardware reset
    > > Add pinctrl of data strobe pin for HS400 mode
    > > Modify eMMC driving settings
    > > Add 400mhz source clock for HS400 mode
    > > Add eMMC HS200/HS400 mode support
    > > Add SD SDR50/SDR104 mode support
    > > Add implement of tune function with CMD19/CMD21
    > >
    > > Chaotian Jing (9):
    > > mmc: core: Add DT bindings for eMMC hardware reset support
    > > mmc: dt-bindings: update Mediatek MMC bindings
    > > mmc: mediatek: make cmd_ints_mask to const
    > > mmc: mediatek: change the argument "ddr" to "timing"
    > > mmc: mediatek: fix got GPD checksum error interrupt when data transfer
    > > mmc: mediatek: add implement of ops->hw_reset()
    > > mmc: mmc: extend the mmc_send_tuning()
    > > mmc: mediatek: add HS400 support
    > > arm64: dts: mediatek: add HS200/HS400/SDR50/SDR104 support
    > >
    > > Documentation/devicetree/bindings/mmc/mmc.txt | 1 +
    > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 11 +-
    > > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 27 ++-
    > > drivers/mmc/core/host.c | 2 +
    > > drivers/mmc/core/mmc_ops.c | 8 +-
    > > drivers/mmc/host/dw_mmc-exynos.c | 4 +-
    > > drivers/mmc/host/dw_mmc.c | 2 +-
    > > drivers/mmc/host/dw_mmc.h | 2 +-
    > > drivers/mmc/host/mtk-sd.c | 296 ++++++++++++++++++++---
    > > drivers/mmc/host/sdhci-esdhc-imx.c | 6 +-
    > > drivers/mmc/host/sdhci-msm.c | 2 +-
    > > drivers/mmc/host/sdhci-sirf.c | 2 +-
    > > include/linux/mmc/core.h | 2 +-
    > > 13 files changed, 314 insertions(+), 51 deletions(-)
    > >
    > > --
    > > 1.8.1.1.dirty
    >
    > I have reviewed the patches, I think they overall looks good! Some
    > comments though.
    >
    > You need to split patch 9, the DT parts enabling hw reset shall go in
    > separately.
    >
    Ok, will separate it at next revision.

    > Regarding the hw-reset changes in patch1, patch6 and patch9, I believe
    > I requested you to separate the HW reset changes from $subject
    > patchset as they are unrelated, please do this.
    >
    As you know, the hw-reset is a part of mmc retune.
    so that I add it to this series.

    > Running checkpatch, it gave me warnings and errors for patch 8.
    > Patch7 didn't apply to my next branch.
    >

    I will fix the checkpatch warnings and errors at next revision.
    by the way, I tried to use "git am
    0007-mmc-mmc-extend-the-mmc_send_tuning.patch" in your branch,
    there was no conflict, so why couldn't apply it ?
    Thx!

    > Kind regards
    > Uffe




    \
     
     \ /
      Last update: 2015-10-22 04:41    [W:4.526 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site