lkml.org 
[lkml]   [2015]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] clocksource/drivers/h8300_*: Remove unneeded memset()s
On Tue, 20 Oct 2015 05:59:24 +0900,
Daniel Lezcano wrote:
>
> From: Alexey Klimov <alexey.klimov@linaro.org>
>
> Memory for timer16_priv, timer8_priv and tpu_priv structs is
> allocated by devm_kzalloc() in corresponding probe functions
> of drivers.
> No need to zero it one more time.
>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---
> drivers/clocksource/h8300_timer16.c | 1 -
> drivers/clocksource/h8300_timer8.c | 1 -
> drivers/clocksource/h8300_tpu.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/clocksource/h8300_timer16.c b/drivers/clocksource/h8300_timer16.c
> index 82941c1..0e076c6 100644
> --- a/drivers/clocksource/h8300_timer16.c
> +++ b/drivers/clocksource/h8300_timer16.c
> @@ -153,7 +153,6 @@ static int timer16_setup(struct timer16_priv *p, struct platform_device *pdev)
> int ret, irq;
> unsigned int ch;
>
> - memset(p, 0, sizeof(*p));
> p->pdev = pdev;
>
> res[REG_CH] = platform_get_resource(p->pdev,
> diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c
> index f9b3b70..44375d8 100644
> --- a/drivers/clocksource/h8300_timer8.c
> +++ b/drivers/clocksource/h8300_timer8.c
> @@ -215,7 +215,6 @@ static int timer8_setup(struct timer8_priv *p,
> int irq;
> int ret;
>
> - memset(p, 0, sizeof(*p));
> p->pdev = pdev;
>
> res = platform_get_resource(p->pdev, IORESOURCE_MEM, 0);
> diff --git a/drivers/clocksource/h8300_tpu.c b/drivers/clocksource/h8300_tpu.c
> index 64195fd..5487410 100644
> --- a/drivers/clocksource/h8300_tpu.c
> +++ b/drivers/clocksource/h8300_tpu.c
> @@ -123,7 +123,6 @@ static int __init tpu_setup(struct tpu_priv *p, struct platform_device *pdev)
> {
> struct resource *res[2];
>
> - memset(p, 0, sizeof(*p));
> p->pdev = pdev;
>
> res[CH_L] = platform_get_resource(p->pdev, IORESOURCE_MEM, CH_L);
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-10-20 07:21    [W:0.419 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site