lkml.org 
[lkml]   [2015]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 03/12] iommu/amd: Don't disable IRQs in __detach_device
Date
From: Joerg Roedel <jroedel@suse.de>

This function is already called with IRQs disabled already.
So no need to disable them again.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/amd_iommu.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index b86c5f0..54e0862 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2198,18 +2198,17 @@ static int attach_device(struct device *dev,
static void __detach_device(struct iommu_dev_data *dev_data)
{
struct protection_domain *domain;
- unsigned long flags;

if (WARN_ON(!dev_data->domain))
return;

domain = dev_data->domain;

- spin_lock_irqsave(&domain->lock, flags);
+ spin_lock(&domain->lock);

do_detach(dev_data);

- spin_unlock_irqrestore(&domain->lock, flags);
+ spin_unlock(&domain->lock);
}

/*
--
1.9.1


\
 
 \ /
  Last update: 2015-10-20 18:01    [W:0.068 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site