Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH v3 3/4] clk: bcm2835: Add support for programming the audio domain clocks. | Date | Fri, 02 Oct 2015 12:53:03 -0700 |
| |
Stephen Boyd <sboyd@codeaurora.org> writes:
> On 09/28, Eric Anholt wrote: >> + >> +static const char *bcm2835_clock_per_parents[] = { >> +static const char *bcm2835_clock_vpu_parents[] = { >> +static const char *bcm2835_clock_osc_parents[] = { > > Can these parent arrays be const char * const ?
They couldn't because I was editing them in place to do the s/"xosc"/of_clk_get_parent_name()/ edit. I've moved the edit to being in a stack allocation at probe time.
I think I've done all of your suggested changes in the new version (and explained the extra ana2 read/write). [unhandled content-type:application/pgp-signature] | |