Messages in this thread | | | Subject | Re: [PATCH] clk: ti: dflt: fix enable_reg validity check | From | Suman Anna <> | Date | Fri, 2 Oct 2015 13:45:52 -0500 |
| |
On 10/02/2015 01:21 PM, Stephen Boyd wrote: > On 09/29, Suman Anna wrote: >> diff --git a/drivers/clk/ti/clkt_dflt.c b/drivers/clk/ti/clkt_dflt.c >> index 90d7d8a21c49..1ddc288fce4e 100644 >> --- a/drivers/clk/ti/clkt_dflt.c >> +++ b/drivers/clk/ti/clkt_dflt.c >> @@ -222,7 +222,7 @@ int omap2_dflt_clk_enable(struct clk_hw *hw) >> } >> } >> >> - if (unlikely(!clk->enable_reg)) { >> + if (unlikely(IS_ERR(clk->enable_reg))) { > > IS_ERR() already has an unlikely inside it, so the unlikely is > redundant here.
Thanks Stephen, didn't realize that. I will fix this up in a subsequent patch, Tero has already staged it and sent a PULL request.
regards Suman
| |