lkml.org 
[lkml]   [2015]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 04/14] perf/bench: Rename 'mem-memcpy.c' => 'mem-functions.c'
    Em Mon, Oct 19, 2015 at 04:35:20PM -0200, Arnaldo Carvalho de Melo escreveu:
    > Em Mon, Oct 19, 2015 at 10:04:20AM +0200, Ingo Molnar escreveu:
    > > So mem-memcpy.c started out as a simple memcpy() benchmark, then
    > > it grew memset() functionality and now I plan to add string copy
    > > benchmarks as well.
    > >
    > > This makes the file name a misnomer: rename it to the more generic
    > > mem-functions.c name.
    > >
    > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    > > Cc: David Ahern <dsahern@gmail.com>
    > > Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
    > > Cc: Jiri Olsa <jolsa@redhat.com>
    > > Cc: Linus Torvalds <torvalds@linux-foundation.org>
    > > Cc: Namhyung Kim <namhyung@kernel.org>
    > > Cc: Peter Zijlstra <peterz@infradead.org>
    > > Cc: Thomas Gleixner <tglx@linutronix.de>
    > > Cc: linux-kernel@vger.kernel.org
    > > Signed-off-by: Ingo Molnar <mingo@kernel.org>
    > > ---
    > > tools/perf/bench/Build | 2 +-
    > > tools/perf/bench/mem-functions.c | 420 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    >
    > Oops, this is not renaming anything, right? And it also introducs
    > __unused usage, which breaks the build.
    >
    > Lemme try to do it...

    Just after applying this patch, I tried a diff and figure this, fixing
    it by just renaming it.

    $ diff -u tools/perf/bench/mem-memcpy.c tools/perf/bench/mem-functions.c
    --- tools/perf/bench/mem-memcpy.c 2015-10-19 15:29:08.761643798 -0300
    +++ tools/perf/bench/mem-functions.c 2015-10-19 15:35:34.986776289 -0300
    @@ -1,7 +1,7 @@
    /*
    - * mem-memcpy.c
    + * mem-functions.c
    *
    - * Simple memcpy() and memset() benchmarks
    + * Simple memcpy() and memset() benchmarks.
    *
    * Written by Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
    */
    @@ -324,7 +324,7 @@
    return (double)(((double)len * iterations) / timeval2double(&tv_diff));
    }

    -int bench_mem_memcpy(int argc, const char **argv, const char *prefix __maybe_unused)
    +int bench_mem_memcpy(int argc, const char **argv, const char *prefix __unused)
    {
    struct bench_mem_info info = {
    .routines = memcpy_routines,
    @@ -407,7 +407,7 @@
    { NULL, }
    };

    -int bench_mem_memset(int argc, const char **argv, const char *prefix __maybe_unused)
    +int bench_mem_memset(int argc, const char **argv, const char *prefix __unused)
    {
    struct bench_mem_info info = {
    .routines = memset_routines,

    \
     
     \ /
      Last update: 2015-10-19 21:01    [W:3.971 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site