Messages in this thread | | | Date | Mon, 19 Oct 2015 16:23:46 +0100 | From | Liviu Dudau <> | Subject | Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe() |
| |
On Mon, Oct 19, 2015 at 04:17:14PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 04:07:50PM +0100, Liviu Dudau wrote: > > The armada DRM driver keeps some old platform data compatibility in the > > probe function that makes moving to the generic drm_of_component_probe() > > a bit more complicated that it should. Refactor the probe function to do > > the platform_data processing after the generic probe (and only if that > > fails). This way future cleanup can further remove support for it. > > I'm mainly using the old code, even with DT based platforms, because it > needs a block of reserved memory which I haven't got around to converting > to DT stuff (each time I've looked into doing that, bits for dealing with > reserved memory nodes were missing.)
Thanks for explaining this!
> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
And thanks for all the ACKs!
Best regards, Liviu
> > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. >
-- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
| |