Messages in this thread | | | Date | Sun, 18 Oct 2015 14:15:36 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH 01/10] tpm, tpm_crb: fix unaligned read of the command buffer address |
| |
On Sun, Oct 18, 2015 at 05:02:55AM +0200, Peter Hüwe wrote: > Am Freitag, 16. Oktober 2015, 20:40:20 schrieb Jarkko Sakkinen: > > + pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) + > > + (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low)); > > The canonical form would be > > + pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) | > > + (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low)); > ? > Or am I missing something? > Shall I fix-up?
Please do. Current works but definitely your form is correct.
> Thanks, > Peter
/Jarkko
| |